Fix upload over 2 gb #524
Merged
Fix upload over 2 gb #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
… don't require it anymore as a result of the removal Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
cosa65
commented
Feb 20, 2024
src/api.v2/helpers/s3/signedUrl.js
Outdated
Comment on lines
46
to
56
| const promises = []; | ||
| const parts = Math.ceil(size / FILE_CHUNK_SIZE); | ||
|
|
||
| for (let i = 0; i < parts; i += 1) { | ||
| promises.push( | ||
| s3.getSignedUrlPromise('uploadPart', { | ||
| ...baseParams, | ||
| PartNumber: i + 1, | ||
| }), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Now we don't try to predict how many parts we'll send, we just send them whenever the read/compress stream makes them available and request a signed url for each of them. This request is managed with the new endpoint in uploadController, which calls the new function getPartUploadSignedUrl
…'t really do anything else Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
cosa65
added
the
safe to run
Signed-off-by: cosa65 <martin@biomage.net>
StefanBabukov
approved these changes
Feb 21, 2024
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 90.11% 89.90% -0.22%
==========================================
Files 169 171 +2
Lines 3754 3765 +11
Branches 429 429
==========================================
+ Hits 3383 3385 +2
- Misses 348 354 +6
- Partials 23 26 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Signed-off-by: cosa65 <martin@biomage.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
URL to issue
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional